Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI update #112

Merged
merged 11 commits into from
Sep 19, 2022
Merged

UI update #112

merged 11 commits into from
Sep 19, 2022

Conversation

danielfdsilva
Copy link
Collaborator

@danielfdsilva danielfdsilva commented Sep 16, 2022

  • Updates the api endpoints to https://staging-*.delta-backend.com
  • Updates delta-ui to the latest main.

Missing:

@danielfdsilva danielfdsilva marked this pull request as ready for review September 16, 2022 09:03
@netlify
Copy link

netlify bot commented Sep 16, 2022

Deploy Preview for visex ready!

Name Link
🔨 Latest commit 3aeca2d
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/632836837960630008ad0444
😎 Deploy Preview https://deploy-preview-112--visex.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hanbyul-here
Copy link
Collaborator

Functionally, everything looks great!
are we planning to replace these missing bg-image etc.? if not, wouldn't it be better to just show an empty background instead for public?

Screen Shot 2022-09-16 at 8 54 19 AM

@slesaad
Copy link
Member

slesaad commented Sep 16, 2022

Also, there are so many missing dataset descriptions. We could probably come up with one-line descriptions for them at least.
Images recommendations:
sea ice thickness: https://unsplash.com/photos/bwD3GLrV4pY
gridded relative deprivation index: https://unsplash.com/photos/3VLHF9b9Plg
nceo africa: https://unsplash.com/photos/0Ws_-v4Y_wY rotated ? or just a screenshot of the data
ocean net primary production: https://unsplash.com/photos/Ko1sGLhZm5w ?

Descriptions:
EPA categories: Might be able to pull from here, they have the same categories; wonder if we can copy word-by-word and cite them or have to reword the description.

@danielfdsilva
Copy link
Collaborator Author

@slesaad I can handle adding the images. If you could help with the descriptions that would be super.

I'll also compile a list of missing content so that we can track

@slesaad
Copy link
Member

slesaad commented Sep 16, 2022

Descriptions:

EPA agriculture
Emissions from agriculture include enteric fermentation, manure management, rice cultivation, and field burning of agricultural residues.
EPA Natural Gas Systems
Emissions from Natural Gas Systems include emissions from natural gas production, processing, transmission, and distribution.
EPA Waste
Waste emissions include landfills, wastewater treatment, and composting.
EPA Coal Mines
Coal mining emissions include state-level emission estimates for underground mines and surface mines.
EPA Petroleum Systems
National emissions from different activities and equipment related to petroleum production, refining, and transport.
EPA Other
Others include emissions from Petrochemical Production, Ferroalloy Production, Combustion (Mobile and Stationary), and Forest Fires.

Actually, I can create a PR.

@aboydnw
Copy link
Contributor

aboydnw commented Sep 16, 2022

Also I just noticed in the demo that the EPA - Agriculture dataset is missing the dash in the title. So it reads "EPA Agriculture" and should read "EPA - Agriculture"

@danielfdsilva
Copy link
Collaborator Author

danielfdsilva commented Sep 16, 2022

@slesaad merged your descriptions into this. Also added the images you proposed.
cc @aboydnw

@danielfdsilva
Copy link
Collaborator Author

Added an image for geoglam (https://unsplash.com/photos/RUj5b4YXaHE)

@danielfdsilva
Copy link
Collaborator Author

Moved the Missing to the issue description

@aboydnw
Copy link
Contributor

aboydnw commented Sep 16, 2022

@danielfdsilva I made some suggestions based on your list.

@slesaad
Copy link
Member

slesaad commented Sep 16, 2022

made the changes in this PR

Copy link
Contributor

@aboydnw aboydnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go once Slesa's branch is merged in.

@danielfdsilva danielfdsilva merged commit d09e67d into develop Sep 19, 2022
@danielfdsilva danielfdsilva deleted the feature/ui-update branch September 19, 2022 09:37
siddharth0248 pushed a commit that referenced this pull request Apr 26, 2024
Update emit-plume-map.png and author text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants