Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow to use OIDC for deployment #292

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

slesaad
Copy link
Member

@slesaad slesaad commented Jul 26, 2023

What am I changing and why

  • Update workflow to use OIDC for deployment
  • Added a DEPLOYMENT_ROLE_ARN repository secret which is the IAM role that Github workflow assumes to deploy

How to test

I tested it by adding test-oidc as one of the trigger branches, and updating the following values:

DOMAIN_PROD: /dashboard
DEPLOY_BUCKET_PROD: covid-eo-uat (confirmed that this was not being used anywhere else first)

This triggered the deployment.
Checked that it worked by grabbing the static website endpoint from the covid-eo-uat and appending /dashboard at the end. The VEDA dashboard looked as expected.
Also checked the cache invalidation in the cloudfront distribution, it worked as expected.

⚠️ Checks

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for visex ready!

Name Link
🔨 Latest commit 702aee9
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/64c195b0fb6dc000080cb72c
😎 Deploy Preview https://deploy-preview-292--visex.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slesaad slesaad mentioned this pull request Jul 26, 2023
@danielfdsilva
Copy link
Collaborator

Thank you @slesaad . This is great

@danielfdsilva danielfdsilva merged commit 357eabf into feature/ci-update Jul 27, 2023
6 checks passed
@danielfdsilva danielfdsilva deleted the test-oidc branch July 27, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants