Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content] Initial Hog Farm Push #380

Open
wants to merge 197 commits into
base: develop
Choose a base branch
from
Open

[Content] Initial Hog Farm Push #380

wants to merge 197 commits into from

Conversation

WeathermanTrent
Copy link
Collaborator

@WeathermanTrent WeathermanTrent commented Apr 15, 2024

Pull Request Contents

  1. New story - 'North Carolina Hog Farms'
  2. Removed old EPA datasets and directed their use from the GHGC STAC
  3. Updated and standardized topic tags on all existing stories and datasets
  4. Updated data visualization zoom extents in some existing stories where map zoom was not set
  5. Added GeoHealth paper citation to HMA heat stress and AOD stories, and changed disclaimer on burn scar story to note a paper is in progress (and added thesis citation to burn scar - will replace with paper citation when published)
  6. Minor prose edits in dataset landing pages to clean them up (bigger standardization effort will come later)
  7. Clarified obscure dataset names
  8. Used internal style for linking to stories from other data story pages
  9. Standardized disclaimer for community contributed stories

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for visex ready!

Name Link
🔨 Latest commit ddec374
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/66fffdfdb05c500008705ac5
😎 Deploy Preview https://deploy-preview-380--visex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines +11 to +14
API_RASTER_ENDPOINT='https://staging.openveda.cloud/api/raster'

# Endpoint for the STAC server. No trailing slash.
API_STAC_ENDPOINT='https://openveda.cloud/api/stac'
API_STAC_ENDPOINT='https://staging.openveda.cloud/api/stac'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still staging? has the data not been pushed to prod yet? if it is, revert this back to production urls

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started a PR a while back for these but I think we need a bit more info to get to production NASA-IMPACT/veda-data#120

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ this was actually a guess at a need when I opened it (right after deleting the old collections). Now it sounds like we want to move forward with these

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can only be merged once all data is available from production data services and we switched the endpoint URLs back to those.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduce file size based on these guidelines - https:/NASA-IMPACT/veda-ui/blob/main/docs/content/frontmatter/media.md

<Block>
<Prose>

###### This story is part of a study conducted on both heat and pollution stress in the Houston Metropolitan Area. [The data story that higlights pollution stress can be found here.](https://www.earthdata.nasa.gov/dashboard/stories/houston-aod)
Copy link
Member

@slesaad slesaad Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -29,6 +33,7 @@ taxonomy:
<Prose>
## Introduction: The 2018 Camp Fire
<mark>🚧 This Discovery presents work in progress and not peer-reviewed results! 🚧</mark>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be called "data stories" instead?

changed peer-review warning label to say "Data Story" rather than "Discovery"
Added the <Link to= {"/stories/story-indicator"]>text</Link> to route internal link to existing Houston AOD data story
Updated formatting ...
Copy link
Contributor

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerikac just confirmed

that the NC-Hogs VEDA data story PR is ready to be merged into Prod (the NLCD PR is not a blocker)

NB: The PR changes a lot of files besides that one story. Mostly adding taxonomy to many existing datasets and stories and removing (or replacing?) EPA datasets.

These changes are should be acknowledge in the PR description.

@j08lue j08lue requested review from slesaad and removed request for slesaad October 17, 2024 13:24
Comment on lines +11 to +14
API_RASTER_ENDPOINT='https://staging.openveda.cloud/api/raster'

# Endpoint for the STAC server. No trailing slash.
API_STAC_ENDPOINT='https://openveda.cloud/api/stac'
API_STAC_ENDPOINT='https://staging.openveda.cloud/api/stac'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can only be merged once all data is available from production data services and we switched the endpoint URLs back to those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants