Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content] NLCD Dataset Landing Page #432

Open
wants to merge 42 commits into
base: develop
Choose a base branch
from
Open

[Content] NLCD Dataset Landing Page #432

wants to merge 42 commits into from

Conversation

acblackford
Copy link
Contributor

Why are you creating this Pull Request?

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for visex ready!

Name Link
🔨 Latest commit 614687a
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/6709ad6681413400080630f4
😎 Deploy Preview https://deploy-preview-432--visex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

datasets/nlcd.data.mdx Outdated Show resolved Hide resolved
@jerikac
Copy link
Contributor

jerikac commented Aug 16, 2024

@slesaad can we get a final review before merging to main? from what I see things are great! Is there anyone on the UI/front end that needs to review before pushing this to production?

@anayeaye
Copy link
Collaborator

Are these datasets ready for production? We have an automated promotion step coming soon but today we will still need to publish to openveda.cloud/api/stac. Also is there a copy of the json used to publish these collections to staging? We can reverse engineer it, too

  • nlcd-new-urbanization
  • nlcd-annual-conus

cc: @jerikac @acblackford @slesaad

Also: please disregard if you all are already in touch about this, I just noticed the PR with staging data!

@acblackford
Copy link
Contributor Author

@anayeaye I sent @slesaad a copy of the jsons. I believe the datasets are ready for publication if those jsons have all of the necessary information.

.env Outdated Show resolved Hide resolved
.env Outdated Show resolved Hide resolved
datasets/nlcd.data.mdx Outdated Show resolved Hide resolved
acblackford and others added 4 commits September 17, 2024 15:17
Co-authored-by: Alexandra Kirk <[email protected]>
Co-authored-by: Alexandra Kirk <[email protected]>
Co-authored-by: Alexandra Kirk <[email protected]>
@anayeaye
Copy link
Collaborator

This PR is blocked by the need to add a custom colormap for the landcover data (NASA-IMPACT/veda-backend#429). The firewall rejects a URL long enough to define the full NLCD colormap definition.

@slesaad
Copy link
Member

slesaad commented Sep 25, 2024

image

the legend needs to be fixed cc @hanbyul-here @sandrahoang686

Comment on lines 218 to 223
## Data Stories Using This Dataset

**[Implications for Heat Stress](https://www.earthdata.nasa.gov/dashboard/stories/urban-heating)**

**[Wildfires Affect Local Weather, Climate, and Hydrology](https://www.earthdata.nasa.gov/dashboard/stories/burn-scar)**

Copy link
Member

@slesaad slesaad Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are internal links. Use <Link> component instead.

See example here

Comment on lines 177 to 179

**[Aerosols and Their Impacts on Houston, TX](https://www.earthdata.nasa.gov/dashboard/stories/houston-aod)**

Copy link
Member

@slesaad slesaad Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal link, use <Link> instead

can you find all of such URLs and update them. See example here
US-GHG-Center@f91b404#diff-fe9d5930d2dd0cea8990f5b70b6181e53c796911fe7f9b0b0c1367a158adeb0fR387-R388

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slesaad I have updated the internal link with style, but the preview is failing due to an unexpected character error ',' . Is this because the story titles used in the link prose have commas?

@hanbyul-here
Copy link
Collaborator

@slesaad It seems the screenshot you captured didn't come from the change of this PR. can you point where I can find the map with the broken style?

@acblackford acblackford changed the title NLCD Dataset Landing Page [Content] NLCD Dataset Landing Page Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants