Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nighlights & HLS to EJ story #58

Merged
merged 6 commits into from
Jun 23, 2022
Merged

Add Nighlights & HLS to EJ story #58

merged 6 commits into from
Jun 23, 2022

Conversation

aboydnw
Copy link
Contributor

@aboydnw aboydnw commented Jun 22, 2022

No description provided.

Copy link
Collaborator

@danielfdsilva danielfdsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the section with all the maps is a bit unbalanced since they are all on the same side. Maybe doing right-left-right improves the flow.

Also, it would be good to use better copy around links in the body (excluding sources) This improves readability and is also better for accessibility.

So, instead of having Explore the Missions https://blackmarble.gsfc.nasa.gov/ we could have something like Explore the Missions at [black marbled's website](https://blackmarble.gsfc.nasa.gov/) - the idea being that the urls are not directly exposed.

Check out some quick tips on accessible links.

@danielfdsilva
Copy link
Collaborator

@aboydnw Reordered the content which is working correctly

@danielfdsilva
Copy link
Collaborator

Also for the tables you were using the Caption element directly.
The Caption component can only be used inside a Figure, since the caption has to be associated with something.
like:

<Figure>
  Some type of figure, like the tables

  <Caption>
    The caption
  </Caption>
</Figure>

In this specific table case there is also no need to add a url, otherwise the little i shows up.

@aboydnw aboydnw merged commit d3da4f4 into develop Jun 23, 2022
@aboydnw aboydnw deleted the ej-hls-nighlights branch June 23, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants