Setup staging deployment #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,7 +65,7 @@ TODO: info | |||
| # Development | |||
| There's not much development to be done in the config repo. The UI part of Delta is stored at [delta-ui](https:/NASA-IMPACT/delta-ui), and connected to the config via a git submodule. | |||
|
|
|||
| **To avoid breaking changes you'll have to manually update the version of delta-ui your config uses.** | |||
| **To avoid breaking changes, the version of `delta-ui` is pinned to a specific commit making use of a [git-submodule](https://www.atlassian.com/git/tutorials/git-submodule).** This allows development to continue without breaking existent instances. | |||
There was a problem hiding this comment.
Can you add documentation about how this pinned commit can be updated for when ui update needs to be deployed?
There was a problem hiding this comment.
Updating the commit involves knowing how git submodules work and which commit you pin it to, depends on the use case. During development we'll most likely pin this to random branches, but I added some docs explaining what is going on and an example to update from main. Should be easy to understand how to apply it to other situations.
Let me know what you think @hanbyul-here .
There was a problem hiding this comment.
Yeah I see. I was not sure where this is done (was thinking if this is saved somewhere in github action config?) , and documentation make it clear where this is done. Thanks!
siddharth0248
added a commit
that referenced
this pull request
Apr 26, 2024
* ODIAC_update * ODIAC_update_v1 * ODIAC_update_v11 * odiac_v12 * ODIAC_update_v2 * ODIAC_update_v2 * ODIAC_update_v22 * ODIAC_v22 * ODIAC_update_v22 * ODIAC_update_v3 * ODIAC_update_v3 * ODIAC_update_v22 * ODIAC_update_v2 * ODIAC_update_v3 * ODIAC_update_v3 * ODIAC_update_v3 * ODIAC_update_v3 * ODIAC_update_v3 * ODIAC_update_v3 * ODIAC_update_v3 * ODIAC_update_v3 * ODIAC_update_v3 * ODIAC_update_v3 * ODIAC_update_v3 * ODIAC_update_v3 * ODIAC_update_v3 * ODIAC_update_v31 * ODIAC_Update_v31 * ODIAC_Update_v31 * ODIAC_update_v31 * ODIAC_Update_v31 * ODIAC_Update_v31 * ODIAC_update_v31 * ODIAC_update_v31 * ODIAC_update_v31 * ch4-test * ch4_test * ch4_test * epa_merge_update * epa_merge_test * epa_merge_test * data_placeholder_update * data_placeholder_update * data_placeholder_update * data_placeholder_update * data_placeholder_update * data_placeholder_update * data_placeholder_update_v1 * data_placeholder_update_v1 * data_placeholder_update_v1 * data_placeholder_update_v1 * data_placeholder_update_v1 * data_placeholder_update_v1 * data_placeholder_update_v1 * data_placeholder_update_v1 * data_placeholder_update_v1 * data_placeholder_update_v1 * data_placeholder_update_v1 * data_placeholder_update_v1 * data_placeholder_update_v1 * data_placeholder_update_v1 * ch4_update_v1 * ch4_wetlands_update_v1 * ch4_wetlands_update_v1 * ch4_wetlands_update_v1 * ch4_wetlands_update_v1 * dataset_placeholder_update_v1 * data_placeholder_update_v11 * data_placeholder_update_v11 * dataset_placeholder_update_v11 * data_placeholder_update_v21 * data_placeholder_update_v21 * data_placeholder_update_v21 * data_placeholder_update_v21 * wetlands_test * wetlands_test * wetlands_test * wetlands_test * wetlands_test * wetlands_test * wetlands_update_v21 * plume_update_v1 * plume_update_v1 * plume_update_v1 * plume_update_v1 * plume_update_v1 * plume_update_v1 * plume_update_v1 * odiac_test * odiac_test * odiac_test * odiac_test * odiac_test * odiac_test * odiac_test * odiac_test * odiac_test * odiac_update * odiac_update * Update stac collection name * Update zoom extent * odiac_plume_update * odiac_plume_update * test * odiac_plume_visual_update * ODIAC_validation_report_test * ODIAC_validation_report_test * test * ODIAC_validation_doc_test * ODIAC_test * ODIAC_v3 * ODIAC_v3 * ODIAC_v3 * ODIAC_v3 * ODIAC_v3 * ODIAC_v3 * ODIAC_v3 * wetlands_daily_test * wetlands_test * wetlands_test * wetlands_test * ODIAC_Wetlands_v3 * test * test * test * test_color * test_colorramp * test * test * test * ODIAC_Wetlands_v1 * ODIAC_Wetlands_GEOS_v1 * ODIAC_Wetlands_CASA_GFED_v1 * ODIAC_Wetlands_CASA_GFED_v1 * casa-gfed-test * CASA_GFED_test * CASA_GFED_test * CASA_GFED_test * CASA_GFED_test * CASA_GFED_test * CASA_GFED_allassets_v1 * header_image_update * sedac_and_header_update * sedac_and_header_image_update * sedac * all_data_v1 * all_dataset_ingested_v1 * test * workflow_update * header_images_update * header_updates * content_update * test * content_update * dataset_content_update_ready to merge * dataset_content_update_ready to merge * sedac_update * test * header_update * header_title_update * 2i2c_demo_ODIAC * resolve_superscript_error * GHG to U.S. GHG * labels_legend_superscript * wetlands_update * Greenhouse_title * sedac_image * taxonomy_update * taxonomy_update * 2i2c * app_title * header_image_resized * odiac_unit_update --------- Co-authored-by: Slesa Adhikari <[email protected]> Co-authored-by: Hanbyul Jo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the GH actions to run content tests and deploy to staging.
The staging url is now: https://vizex.surge.sh/
Currently is shows "Welcome to undefined", and although poetic this will be fixed once this is merged.
I added some of the dummy content we had in the
delta-uimock folder, but we should include better one.The workflow is simple: Branch from
develop, open a PR and merge. This will trigger a deploy.Whenever we want to update the
delta-uiversion, we need to update the git submodule reference.@hanbyul-here I added some docs explaining the configuration. Please have a look as an outside view would be very valuable to ensure that this is clear.