Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodata masks for TWS datasets and un-reverse colormap #81

Closed
wants to merge 4 commits into from

Conversation

anayeaye
Copy link
Collaborator

What

  • added nodata values to tws dataset config files
  • changed colormap to rdylbu to agree with legend stops

How tested

Served locally and reviewed on localhost. While the change was minor I ended up needing to rerun the setup to run successfully.

git submodule update --init --recursive
./.delta/setup

@netlify
Copy link

netlify bot commented Jul 21, 2022

Deploy Preview for visex ready!

Name Link
🔨 Latest commit a35cacb
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/62d9b737dee0e8000a42fb3c
😎 Deploy Preview https://deploy-preview-81--visex.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@anayeaye
Copy link
Collaborator Author

@sahmad3 - I think these are the changes you were asking for: using the regular rdylbu colormap and masking nodata values. I think this is the desired configuration? Please feel free to take over this PR and/or selectively use the suggested changes.
tws-cfg
?

@sahmad3
Copy link
Collaborator

sahmad3 commented Jul 21, 2022

@anayeaye thanks, nodata looks good, but the legend at the bottom right should be reversed (red for -ve and blue for +ve). I was trying that by reversing the colors in 'stops' but that was causing fatal error. Any other way to reverse the legend?

@sahmad3
Copy link
Collaborator

sahmad3 commented Jul 21, 2022

@anayeaye I worked around that issue of reversing colors on the colorbar by switching the min max values. So the values correspond to color now but vary from 1(blue) to -1 (red). This is fine for now, but let me know if you can find a better solution

@anayeaye
Copy link
Collaborator Author

@sahmad3 - I misunderstood. The anomaly colormap (and legend) should be the reverse of the trend?
tws-cfg-2

@sahmad3
Copy link
Collaborator

sahmad3 commented Jul 21, 2022

@anayeaye no both should follow same colors (red for -ve values, blue for +ve values).
Your anomaly colormap now looks perfect. Can we do the same for trend colormap? Sorry for any confusion on this

@anayeaye
Copy link
Collaborator Author

🙃 @sahmad3 I think this might be it:
tws-cfg-3

@sahmad3
Copy link
Collaborator

sahmad3 commented Jul 21, 2022

@anayeaye yep this is it!

@anayeaye
Copy link
Collaborator Author

@sahmad3 I made the change the same as you did--by reversing the stops in the legend. Maybe there was a stray formatting error like an extra space somewhere? I also stopped the server and ran yarn clean, if that helps any.

There is one additional change in this branch: I expanded the datetime format in the compare panel for the anomaly dataset so that the text showed two different dates for the same year.

@sahmad3
Copy link
Collaborator

sahmad3 commented Jul 21, 2022

thanks @anayeaye ! I have a few minor changes to the text blocks that I will commit here ingesting your edits.

@sahmad3
Copy link
Collaborator

sahmad3 commented Jul 21, 2022

@anayeaye I have added another commit #82 ingesting all the edits. Hoping it can go to production

@anayeaye
Copy link
Collaborator Author

This PR is no longer needed, all fixes are in #82

@anayeaye anayeaye closed this Jul 21, 2022
@anayeaye anayeaye deleted the fix/reverse-twsanomaly-colormap branch July 21, 2022 22:19
siddharth0248 pushed a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants