Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sourceparams as it is when it is there #1148

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

hanbyul-here
Copy link
Collaborator

@hanbyul-here hanbyul-here commented Sep 11, 2024

Related Ticket: {link related ticket here}

Description of Changes

While working on render extension talk, I realized that the authors don't necessarily use array format for rescale value (ex. rescale value for hls-ndvi layer in this file: https://raw.githubusercontent.com/NASA-IMPACT/veda-config/develop/datasets/hls-ndvi-ian.data.mdx is string -1,1) To support what we have now, I think we should return the source parameter as it is.

Notes & Questions About Changes

I also simplified the logic a little bit, please check if I am missing anything!

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 778d327
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/66e4735f49c7820008614704
😎 Deploy Preview https://deploy-preview-1148--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@dzole0311 dzole0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying this @hanbyul-here! 🙏

While working on render extension talk, I realized that the authors don't necessarily use array format for rescale value

Just a note, the discussion we had here was the discreptancy between how Parcel outputs the rescale string. So the rescale from the mdx would be output as [1, -1] by Parcel, but titiler would return a nested array ([[1, -1]]), thus the flattening we're doing.

@hanbyul-here hanbyul-here merged commit 98cc2d7 into main Sep 13, 2024
8 checks passed
@hanbyul-here hanbyul-here deleted the accept-source-params branch September 13, 2024 17:20
sandrahoang686 added a commit that referenced this pull request Sep 25, 2024
## 🎉 Features
- [E&A] Implement colormap configurability
#1117
- [E&A] Feature flag colormap configurability
#1147
- Add font md size as 20px for new Design System
#1125
## 🚀 Improvements
- [E&A] Return default value of colormap along with other settings
#1128
- Create new raster paint layer module and factor out
BaseTimeseriesProps #1105
- Consolidate a place where to check linkProps
#1121
#1160
- Expose Data Catalog and update child components to pass in routing/nav
for library build #1096
#1159
- Set up eslint rule for no trailing spaces
#1146
- Replace cmr-stac with titiler-cmr
#1131
## 🐛 Fixes
- Update external link in top navigation target
#1145
- Update PageHeader/Nav to not throw
#1149
- [E&A] Fix to convert the time to usertzdate
#1151
- Use sourceparams as it is when it is there
#1148
- Fix compare label on block map
#1153
- Discard the previous sourceExclusive value to fix the case when the
datasets with different sourceExclusive can be selected together
#1161
- Show the name of the selected filter on story hub
#1161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants