Implement Darwin v7 reader and improve annotation class #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduces a breaking change (!)
- Bumped pydantic to >2.0.0 - Added mypy to the dev requirements - Cleanup variables and code in annotations.py
github-actions
bot
added
the
documentation
dlup/annotations.py
Outdated
|
|
||
| # Now we can make WsiSingleLabel annotations | ||
| output = [] | ||
| for an_cls in annotations: |
There was a problem hiding this comment.
for an_cls, coordinates in annotations.items():
output.append(WsiSingleLabelAnnotation(a_cls=an_cls, coordinates=coordinates))
return cls(output)There was a problem hiding this comment.
Just a very small change to make it a bit more explicit that we get the "coordinates"
|
Looks good :). Here is an test json file for testing darwin parsing: |
martvanrijthoven
approved these changes
Aug 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggested changes have two major changes
WsiAnnotationsare now a class rather than a string. This means that you can haveAnnotationClasswith the label 'tumor' and the type being any AnnotationTypeWe have also included the changes of #157