Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes{#191} #192

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Fixes{#191} #192

merged 5 commits into from
Nov 15, 2023

Conversation

AjeyPaiK
Copy link
Member

@AjeyPaiK AjeyPaiK commented Nov 14, 2023 •
edited
Loading

This PR implements:

  1. Adds a boolean flag use_limit_bounds to the SlideImage.get_scaled_size() function which returns the scaled bounded size.

jonasteuwen
jonasteuwen approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasteuwen jonasteuwen merged commit 31fe728 into main Nov 15, 2023
8 checks passed
@jonasteuwen jonasteuwen deleted the fix-slideimage-limit-bounds branch November 15, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasteuwen jonasteuwen jonasteuwen approved these changes

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AjeyPaiK @jonasteuwen