Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic annotation reader and writers #255

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

jonasteuwen
Copy link
Contributor

This PR implements dynamic loading of importer and exporters for SlideAnnotations significantly simplifying the code (the current SlideAnnotations was over 1000 lines).

In addition WsiAnnotations has been removed.

moerlemans
moerlemans previously approved these changes Sep 26, 2024
Copy link
Contributor

@moerlemans moerlemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mypy is failing.

Furthermore, I ran some easy experiments with a halo_xml file. All works good. Code looks good to me.

@jonasteuwen jonasteuwen merged commit 92ebd51 into main Sep 26, 2024
7 checks passed
@jonasteuwen jonasteuwen deleted the feature/importer-exporer branch September 26, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants