-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to new commondata names in docs, examples and tests #1969
Comments
Dear @RoyStegeman, @peterkrack and I are willing to help change the names in this PR. I have a question regarding the docstrings in vp. Where do we exactly specify the dataset names? |
Thanks a lot! In the docstrings we regularly provide examples of how a function can be used (through the API). I put it separately because while the names in the tests can be updated and as long as the tests pass afterwords it's fine, the doctring examples may need to be tested. Feel free to do them simultaneously, but to me it made sense to separate them. |
Sorry this is not complete, if I just do a bruteforce search for the old names I still find plenty |
Really? My bad, then. I thought I had fixed them all. |
No worries, it doesn't look like there are many left, but it's a bit early to close this |
I'll have a second pass, then. |
Thanks, though if you don't have the time I'm sure we can include it in the list of tasks to be delegated in Morimondo |
Perhaps you meant the illustrious list of missions that will be assigned to honoured researchers in Morimondo. |
Yes that's what I meant to type. Damn autocorrect! |
The text was updated successfully, but these errors were encountered: