Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the system of suggestions in validphys / config #2152

Open
scarlehoff opened this issue Sep 16, 2024 · 0 comments
Open

Fix the system of suggestions in validphys / config #2152

scarlehoff opened this issue Sep 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@scarlehoff
Copy link
Member

Due to the way the new commondata is implemented (grouped by paper), the suggestions (that looks at the entries in the folder) when a name is incorrect don't work anymore.

Fixing it should be a question of looking into config.py / loader.py and making sure a list of all datasets is available.

The only important thing to take into account is that it cannot be done at import time since listing all available datasets now require looping over metadata.yaml files, parsing them and constructing the dataset names.

@scarlehoff scarlehoff added the bug Something isn't working label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant