-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifications to address sugestions by JOSS reviewers #199
Merged
Merged
Changes from 5 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
3fe059c
Addressing #190
shirubana 8b7c683
Addresses #192, #193
shirubana c0334b1
Addressing #194
shirubana f21b502
update Linux installation and make_gencumsky note.
cdeline cd709aa
move make_gencumsky directions into optional note.
cdeline 76c2767
pytest getEPW
shirubana bedea2a
remove HPCExample from main.py, add HPCExample Tutorial Notebook
shirubana 856049c
quickExample fix #201 and pytest
shirubana f2297f2
pytest TorqueTubes on Modules
shirubana 1252917
added test_1axis_gencumSky()
shirubana 08a579e
makeSCene1axis test for sceneDict with Pitch and with GCR (#204 test)
shirubana 9d1c6fa
pytest Torquetubes smallfix
shirubana a039529
pytest gendaylit2manual, small fix test_1axis_genCumSky()
shirubana 2f05732
add test for makeImage and makeFalseColor, small fix gendaylit2manual…
shirubana 98932d3
pytest sceneDict HEIGHT options on makeScene1axis
shirubana e0af625
added small pytests
shirubana c5cafa0
pytest getSingleTimestampTrackerAngle
shirubana c2386c8
Removed deprecated nMods and nRows inputs and warning to makeScene1axis
shirubana 27f4ef8
pytest smallfix
fe3923f
dumb dumb fix
a452fd2
update to DOE citation #213
ea8e752
pytest otherfix and notes
04db364
Merge branch 'master' into master-JOSS
shirubana f5ebf9e
added citations paper.md #197 #193
2cc760e
improvements to contributing #196
af43110
platform and python version updates #198
3ee75cd
Update installation.rst
d360efa
package overview #191
b090a15
small fix #217
shirubana 7a9000a
journal2 path fix #217
shirubana 8c0f63e
installation PR fix
shirubana 9047fdf
update installation.rst
shirubana 6338954
remove extraneous tutorial1 .py file
cdeline 1df9d2d
Merge branch 'master-JOSS' of https:/NREL/bifacial_radian…
cdeline d847937
Revert "Removed deprecated nMods and nRows inputs and warning to make…
cdeline File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, indicate somewhere that these video instructions are for Windows only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://youtu.be/4A9GocfHKyM <https://youtu.be/4A9GocfHKyM>
_ This video shows how to install the bifacial_radiance software and all associated softwares needed for Windows. More info on the Wiki. Instructions for Windows and Linux-based OS are also shown below.Also updated on info of the youtube video and title of the youtube video