Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tolerate pip 19.3 for --pyprof builds #681

Closed
wants to merge 1 commit into from

Conversation

hartb
Copy link

@hartb hartb commented Jan 8, 2020

The 'main' function was moved between pip 19.2.3 and 19.3, which
causes '--pyprof' build to fail with (at least) pip 19.3 and 19.3.1:

Traceback (most recent call last):
  File "setup.py", line 37, in <module>
    pipmain(["install"] + required_packages)
TypeError: 'module' object is not callable

A permanent solution for this might require rewriting the '--pyprof'
install section to use 'python -m pip', but this change just adjusts
the import to tolerate the 19.3 change.

See:

The 'main' function was moved between pip 19.2.3 and 19.3, which
causes '--pyprof' build to fail with (at least) pip 19.3 and 19.3.1:

    Traceback (most recent call last):
      File "setup.py", line 37, in <module>
        pipmain(["install"] + required_packages)
    TypeError: 'module' object is not callable

A permanent solution for this might require rewriting the '--pyprof'
install section to use 'python -m pip', but this change just adjusts
the import to tolerate the 19.3 change.

See:

- pypa/pip@09fd200
- pypa/pip#7498
- pypa/pip#7499
@hartb
Copy link
Author

hartb commented Jan 8, 2020

See #680

@mcarilli
Copy link
Contributor

mcarilli commented Jan 8, 2020

Should be fixed now via #652, I thought we merged that already.

@mcarilli mcarilli closed this Jan 8, 2020
@hartb hartb deleted the hartb-pipfix branch January 8, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants