iOS-586 Implement logic to add expiration date to banned books and remove expired banned books #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS-584 Disable ipa upload to firebase
…ired banned books
ettore
reviewed
Nov 17, 2023
There was a problem hiding this comment.
this looks sound to me. I just have a few refactoring suggestions, mainly to make the code express the "banned books" stuff more clearly. Overall pretty minor stuff, but let me know what you think.
Thanks for this and for adding meaningful comments, this will be easy to forget.
ettore
approved these changes
Nov 20, 2023
| @@ -106,7 +106,8 @@ @interface NYPLOPDSAcquisition () | |||
| @property (nonatomic, copy, nonnull) NSString *type; | |||
| @property (nonatomic, nonnull) NSURL *hrefURL; | |||
| @property (nonatomic, nonnull) NSArray<NYPLOPDSIndirectAcquisition *> *indirectAcquisitions; | |||
| @property (nonatomic, nonnull) id<NYPLOPDSAcquisitionAvailability> availability; | |||
| /// The NYPLOPDSAcquisitionAvailability property is omitted here because it's no longer a read only object. | |||
There was a problem hiding this comment.
nit: while this is true, it is also the default in objective-c so I don't think it's needed.
ExplorerNautilus
force-pushed
the
iOS-586
branch
from
909a295
to
346eab0
Compare
ExplorerNautilus
force-pushed
the
iOS-586
branch
from
e565795
to
f0eee0f
Compare
ExplorerNautilus
force-pushed
the
iOS-586
branch
from
f0eee0f
to
0a65d96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
Add expiration date to banned books
Remove expired banned books
CI fixes that already merged into release branch
Why are we doing this? (w/ JIRA link if applicable)
iOS-586
How should this be tested? / Do these changes have associated tests?
See test cases in ticket
Dependencies for merging? Releasing to production?
N/A
Does this include changes that require a new SimplyE/Open eBooks build for QA?
Yes
Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
@ExplorerNautilus