Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probable mistake in Sleigh documentation #6987

Open
hippietrail opened this issue Oct 1, 2024 · 0 comments
Open

Probable mistake in Sleigh documentation #6987

hippietrail opened this issue Oct 1, 2024 · 0 comments

Comments

@hippietrail
Copy link
Contributor

Describe the bug
In docs/languages/html/sleigh_constructors.html section 7.7.2.5. "Branching Statements", it seems one term is included twice while another is left out.

There are six forms covering the gamut of typical assembly language branches, but in terms of actual semantics there are really only three. With p-code,

  • CALL is semantically equivalent to BRANCH,
  • CALLIND is semantically equivalent to BRANCHIND, and
  • RETURN is semantically equivalent to BRANCHIND.

Since BRANCHIND occurs twice, does that mean there's really only five forms? Or is the duplication of BRANCHIND a mistake?
If it's a mistake and should only occur once, which one is the right one?

But then three paragraphs later we have:

Where a direct address is needed, as for the BRANCH, CBRANCH, and CALL instructions, ...

So it would seem that this CBRANCH is probably the term missing from the list. If so, which BRANCHIND should it replace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant