Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Keycloak #464

Conversation

shanesoh
Copy link
Contributor

Resolves #463

@rmmayo rmmayo self-assigned this Mar 30, 2021
@rmmayo rmmayo self-requested a review March 30, 2021 20:03
@rmmayo
Copy link
Collaborator

rmmayo commented Mar 30, 2021

Added comment to the ticket: #463 (comment)

…vice into ticket#463/add_oauth2_support_for_keycloak
Copy link
Collaborator

@rmmayo rmmayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @shanesoh - could you please just add a simple test to the skills.auth.OAuth2UserConverterServiceSpec testing the KeycloakUserConverter?

@shanesoh
Copy link
Contributor Author

shanesoh commented Apr 2, 2021

@rmmayo Just did. Please take a look. Thanks!

Copy link
Collaborator

@rmmayo rmmayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@rmmayo rmmayo merged commit 696b216 into NationalSecurityAgency:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OAuth2 support for Keycloak
2 participants