Add support for querying HLLSketch types #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These represent approximate distinct counts. We can treat them as longsum/counters. Usage will be nuanced, we'll probably need to ensure callers are performing per-step queries for the results to make sense.
brharrington
reviewed
May 9, 2023
| @@ -439,6 +439,7 @@ object DruidDatabaseActor { | |||
| case Histogram(_) if metric.isDistSummary => Aggregation.distSummary(metric.name) | |||
| case DataExpr.GroupBy(e, _) => toAggregation(metric, e) | |||
| case DataExpr.Consolidation(e, _) => toAggregation(metric, e) | |||
| case _: DataExpr.Sum if metric.isSketch => Aggregation.distinct(metric.name) | |||
There was a problem hiding this comment.
So if other aggregates are used with this type, what will the behavior be? Would it be better to just use the distinct behavior for any aggregate function?
There was a problem hiding this comment.
Yes, that's a good point. We wouldn't do anything different if called with max or min. I'll change to always use this aggregator for columns of this type.
brharrington
approved these changes
May 9, 2023
manolama
pushed a commit
to manolama/iep-apps
that referenced
this pull request
Oct 25, 2023
These represent approximate distinct counts. We can treat them as longsum/counters. Usage will be nuanced, we'll probably need to ensure callers are performing per-step queries for the results to make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These represent approximate distinct counts. We can treat them as longsum/counters. Usage will be nuanced, we'll probably need to ensure callers are performing per-step queries for the results to make sense.