Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace code that assumes US/Pacific time zone #74

Open
andrewmwhite opened this issue Sep 27, 2017 · 2 comments
Open

Replace code that assumes US/Pacific time zone #74

andrewmwhite opened this issue Sep 27, 2017 · 2 comments

Comments

@andrewmwhite
Copy link
Contributor

The LANDESK plugin (in the stethoscope/plugins/sources/landesk package) assumes a timezone of US/Pacific in a few places. These should be replaced with UTC and any comparisons elsewhere (like when last_sync is checked during filtering) should altered to make sure the conversion is done there instead of storing these as US/Pacific.

@suprithcs
Copy link

Hi Andrew, I've started to work on this. During filtering, we should convert to US/Pacific or local timezone?

@andrewmwhite
Copy link
Contributor Author

Probably store as UTC and then check against local timezone when filtering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants