Skip to content

Commit

Permalink
Add support for overriding version string
Browse files Browse the repository at this point in the history
  • Loading branch information
romain-intel committed Sep 11, 2024
1 parent f14fcb5 commit 0434e97
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 5 deletions.
13 changes: 9 additions & 4 deletions metaflow/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ class and related decorators.
from .runner.nbdeploy import NBDeployer

__version_addl__ = []
__version_override__ = None
_ext_debug("Loading top-level modules")
for m in _tl_modules:
extension_module = load_module(m)
Expand All @@ -164,11 +165,15 @@ class and related decorators.
ext_version = _format_git_describe(
_call_git_describe(cwd=os.path.dirname(extension_module.__file__))
)
ext_override = None
if ext_version is None:
ext_version = extension_module.__version__
if ext_version:
version_info = "%s(%s)" % (version_info, ext_version)
__version_addl__.append(version_info)
ext_version = getattr(extension_module, "__version__", "<unk>")
ext_override = getattr(extension_module, "__name_override__", None)
if ext_override:
__version_override__ = "%s %s" % (ext_override, ext_version)
__version_addl__.clear()
else:
__version_addl__.append("%s(%s)" % (version_info, ext_version))

if __version_addl__:
__version_addl__ = ";".join(__version_addl__)
Expand Down
3 changes: 2 additions & 1 deletion metaflow/metaflow_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,13 +153,14 @@ def get_version(public=False):
import metaflow

version_addl = metaflow.__version_addl__
version_override = metaflow.__version_override__

version = format_git_describe(
call_git_describe(cwd=path.dirname(metaflow.__file__)), public=public
)

if version is None:
version = metaflow.__version__
version = version_override or metaflow.__version__

if version_addl:
return "+".join([version, version_addl])
Expand Down

0 comments on commit 0434e97

Please sign in to comment.