Fix race condition

Netflix · Sep 13, 2024 · bb8f72a · bb8f72a
1 parent 9c313df
commit bb8f72a
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/metaflow/runner/utils.py b/metaflow/runner/utils.py
@@ -48,6 +48,12 @@ def read_from_file_when_ready(
  content = file_pointer.read()
  while not content:
  if command_obj.process.poll() is not None:
+ # Check to make sure the file hasn't been read yet to avoid a race
+ # where the file is written between the end of this while loop and the
+ # poll call above.
+ content = file_pointer.read()
+ if content:
+ break
  raise CalledProcessError(
  command_obj.process.returncode, command_obj.command
  )