Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruction to setup on AWS is not clear #44

Closed
Jeffwan opened this issue Dec 10, 2019 · 8 comments
Closed

Instruction to setup on AWS is not clear #44

Jeffwan opened this issue Dec 10, 2019 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@Jeffwan
Copy link

Jeffwan commented Dec 10, 2019

I can not successfully finish the aws setup. I use CloudFormation Template here https:/Netflix/metaflow-tools/tree/master/aws/cloudformation and it gives me all the resources I need to use here.
image

When I do metaflow configure aws, As I understand, I need to put output resources arns there. But I notice

  1. It's hard for me to map resources to configurations. For example,
  • Please enter the job queue to use for batch: -> Queue name or ARN?

  • Please enter the IAM role to use for the container to get AWS S3 access -> Is it ECSJobRole from CF outputs?

  • Please enter the URL for your metadata service: -> Is it the ServiceUrl? There's another one InternalServiceUrl.

  1. Some configuration we can not find in the CloudFormation outputs
  • Please enter the default container image to use -> Can not find any instruction here. I assume we at least need to have python env for the base container image?

  • Please enter the container registry -> should be <account_id>.dkr.ecr.us-west-2.amazonaws.com

I would suggest to improve the doc here.
https://docs.metaflow.org/metaflow-on-aws/deploy-to-aws

@savingoyal
Copy link
Collaborator

@Jeffwan - Thanks for trying out Metaflow!

  1. Mapping resources to configurations -
  • You can use either the queue name or the ARN
  • Yes, indeed it is the ECSJobRole
  • Please use ServiceUrl
  1. Image configuration - these were intended to be optional. Our next release will fix them
  • Yes, indeed. For now (till we release 2.0.1), please use python:latest image
  • You can use docker.io

These issues will be fixed promptly in the next release.
cc @seeravikiran

@crk-codaio
Copy link
Contributor

@Jeffwan Thanks indeed for the thoughtful feedback.

@savingoyal savingoyal added the bug Something isn't working label Dec 11, 2019
@anishpdalal
Copy link

anishpdalal commented Dec 12, 2019

I really like the design and feel of Metaflow so far! I'd like to get it working with AWS, and I'm also having trouble with configuration as well.

I exported the environment variable:

export METAFLOW_DATASTORE_SYSROOT_S3=metaflow-tutorial-metaflows3bucket-85sqqazcntjh

but when I run python 05-helloaws/helloaws.py run it appears that the bucket name doesn't register and I get the following message:

Screen Shot 2019-12-12 at 11 19 55 AM

I made sure that export METAFLOW_DEFAULT_METADATA=service and export METAFLOW_DEFAULT_DATASTORE=s3 were ran.

Also, I ran metaflow configure aws and it generated the config.json file. But when I run python 05-helloaws/helloaws.py run I got a message saying that METAFLOW_SERVICE_URL wasn't defined which leads me to believe the config file isn't getting loaded. Do I need to specify a path to the config file when I call run?

Thanks for your help!

@savingoyal
Copy link
Collaborator

savingoyal commented Dec 12, 2019

@anishpdalal Yes, there is a bug report for this. It should be fixed in the next release, which is scheduled in the next couple of days. Can you prepend s3:// to METAFLOW_DATASTORE_SYSROOT_S3?

@anishpdalal
Copy link

Yes that worked thanks!

@Jeffwan
Copy link
Author

Jeffwan commented Dec 12, 2019

@anishpdalal Yeah, you got it. The instruction needs to be improved. Same on the code side, for this case, probably check if there's no protocols, use s3:// by default.

savingoyal added a commit that referenced this issue Dec 16, 2019
@savingoyal
Copy link
Collaborator

There is a new README accompanying the cfn template now, as well as the metaflow configure aws command has been revamped in v2.0.1.

@Jeffwan
Copy link
Author

Jeffwan commented Dec 26, 2019

Great work! Thanks

valayDave pushed a commit that referenced this issue Jan 24, 2022
AdamGoode added a commit to AdamGoode/metaflow that referenced this issue Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants