Add a method to list the name of the parameters for a flow. #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can now do:
for name in self.parameters:
print('I have a parameter %s with a value of %s' % (name, getattr(self, name)))
conflicts with user variables
savingoyal
reviewed
Mar 2, 2020
|
I thought about that and decided for just the names to respect the lazy loading (a use case may be that you are looking for a specific parameter and don’t want to load all of them). Basically push the cost only to the “using it” path.
…Sent from my iPhone
On Mar 2, 2020, at 14:16, Savin ***@***.***> wrote:
@savingoyal commented on this pull request.
In metaflow/current.py:
> @@ -10,6 +10,7 @@ def __init__(self):
self._namespace = None
self._username = None
self._is_running = False
+ self._parameter_names = None
Should these be just parameters? Maybe the structure could be a dictionary of names and values?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
savingoyal
approved these changes
Mar 3, 2020
tuulos
reviewed
Mar 4, 2020
metaflow/current.py
Outdated
| return self._parameter_names | ||
| raise RuntimeError("Parameter names not set") | ||
|
|
||
| @parameter_names.setter |
There was a problem hiding this comment.
@romain-intel use current._update_env for setting parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #137 .
You can now do:
for name in current.parameter_names:
print('I have a parameter %s with a value of %s' % (name, getattr(self, name)))