student attempt at implementing termination of step function execution #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikonen
reviewed
Oct 27, 2023
| @@ -82,8 +82,18 @@ def list_executions(self, state_machine_arn, states): | |||
| ) | |||
|
|
|||
| def terminate_execution(self, state_machine_arn, execution_arn): | |||
| # TODO | |||
| pass | |||
| try: | |||
There was a problem hiding this comment.
this still needs a counterpart in the step_functions_cli.py so the function can be called through the CLI. You can see how the command has been implemented in argo_workflows_cli.py for some example on the plumbing.
Another thing that needs to be implemented for this feature is a validate_run_id (again, similar to argo CLI) which checks that the run_id the user has provided belongs to the correct flow/project/user and has a matching token.
This is to guard against being able to issue arbitrary commands such as
python anyflow.py step-functions terminate not-my-run-id
|
Closing since #1695 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seemed like there was an open issue with regards to the lack of implementation of the termination of a step function and I made an attempt to implement it. Would love feedback / help in getting this implemented!! Im still learning so I appreciate any and all feedback :)