fix overwrite of neuron devices when efa devices are also specified #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emattia
force-pushed
the
eddie/efa-trainium-batch-bug
branch
from
18cf8b5
to
b7b5c94
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * Setup a new card and start the watcher | ||
| */ | ||
| function handleLoadCard(name, value) { | ||
| document.getElementsByTagName("title").innerHTML = name; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
| function handleLoadCard(name, value) { | ||
| document.getElementsByTagName("title").innerHTML = name; | ||
| const iframe = document.getElementById("card-frame"); | ||
| iframe.src = `/card/${value}?embed=true`; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
emattia
force-pushed
the
eddie/efa-trainium-batch-bug
branch
from
b7b5c94
to
c0a858c
Compare
…ermissions in job definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
@batchcontains bothinferentiaandefaarguments, the list of/dev/neuron{N}(for inferentia and trainium) specifications innodeProperties.nodeRangeProperties.container.linuxParameters.devicesare currently being overwritten by the list of/dev/infiniband/uverbs{N}(for efa eni's) devices.