fix: decorator init order #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing[589] @ fbb84f7 |
|
The use case for this also requires #1667 being fixed |
savingoyal
approved these changes
Jan 8, 2024
|
Testing[589] @ fbb84f7 had 14 FAILUREs. |
|
tried out decorators that rely on |
romain-intel
approved these changes
Jan 11, 2024
madhur-ob
pushed a commit
to madhur-ob/metaflow
that referenced
this pull request
Jan 18, 2024
emattia
pushed a commit
to emattia/metaflow
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
separate the
task_pre_stepandtask_decoratein order to support better setup-order of dependent decorators.Specifically we want the
PATHpatching of conda-decorator to happen early so that other decorators can rely on this aftertask_pre_stepin the lifecycle.