Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add __repr__ and __str__ methods to Parameter #1714

Merged
merged 2 commits into from
Feb 7, 2024
Merged

add __repr__ and __str__ methods to Parameter #1714

merged 2 commits into from
Feb 7, 2024

Conversation

raybellwaves
Copy link
Contributor

@raybellwaves raybellwaves commented Feb 2, 2024 •
edited
Loading

Closes #1712

This is how it looks

Screenshot 2024-02-02 at 2 01 20 PM

@madhur-ob
Copy link
Collaborator

Hi @raybellwaves
Might I ask what is the use-case for this particular change / what is being achieved? Is it only for aesthetic purposes?

@raybellwaves
Copy link
Contributor Author

Hi @raybellwaves Might I ask what is the use-case for this particular change / what is being achieved? Is it only for aesthetic purposes?

I mentioned it here (#1712 (comment))

to improve understanding and debugging

savingoyal
savingoyal previously requested changes Feb 6, 2024
View reviewed changes
metaflow/parameters.py Outdated Show resolved Hide resolved
@nflx-mf-bot
Copy link
Collaborator

Testing[629] @ a8e247c

romain-intel
romain-intel approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@romain-intel romain-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided no issues with tests (shouldn't be) LGTM.

@saikonen saikonen dismissed savingoyal’s stale review February 7, 2024 09:39

requested changes have been done.

@nflx-mf-bot
Copy link
Collaborator

Testing[629] @ a8e247c had 1 FAILURE.

@saikonen saikonen merged commit 564669f into Netflix:master Feb 7, 2024
30 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-intel romain-intel romain-intel approved these changes

@savingoyal savingoyal savingoyal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add __repr__ methods to Parameter
6 participants
@raybellwaves @madhur-ob @nflx-mf-bot @savingoyal @romain-intel @saikonen