Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Argo Workflows JSONType parameters with default values sometimes not working #2059

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

saikonen
Copy link
Collaborator

due to changes in parameter quoting in the CLI, passing jsontype parameter default values has stopped working. Attempt to mend the issue with this PR

parameter default testing needs to cover:

  • basic argo-workflows trigger --param_name value functionality
  • cronworkflow parameter defaults with @schedule
  • Argo Events payload parameter mapping

@saikonen saikonen marked this pull request as ready for review September 26, 2024 08:16
@savingoyal savingoyal merged commit a4f1932 into master Sep 30, 2024
26 checks passed
@savingoyal savingoyal deleted the fix/argo-parameters-default-value-quotes branch September 30, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants