Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit of open source R binding #214

Merged
merged 129 commits into from
Aug 5, 2020
Merged

Initial commit of open source R binding #214

merged 129 commits into from
Aug 5, 2020

Conversation

jasonge27
Copy link
Contributor

Trigger github actions on R tests.

savingoyal and others added 12 commits April 13, 2020 10:34
@savingoyal
Add hook for metaflow R bindings
4465e9e 
Adds necessary hooks for customizing process entry-points to
R executables. This patch preps for the eventual metaflow-R
release.

Addresses #1
@jasonge27
Merge branch 'master' into R-dev
eb8ce5b
@jasonge27
update the R hooks in R.py
6f798b8
@jasonge27
fixed a typo
1787fbd
@savingoyal
Handle CloudWatchLogs resource creation delay gracefully
ee2a6a3 
CloudWatchLogStream might not be immediately created (and may never
be created if say the job fails to pull the docker image for any reason
whatsoever). We can simply retry again next time.
@jasonge27
Merge remote-tracking branch 'origin/logstream-delay' into R-dev
3eef2ec
@jasonge27
fixed entrypoints and package paths for R batch run
994cdf1
@jasonge27
Merge branch 'master' into R-dev
c79e46f
@jasonge27
initial commit of open source Metaflow R binding
be9f8c7
@jasonge27
update github actions for R tests
8aa45e8
@jasonge27
update github actions for R-dev
20c2f65
@jasonge27
update github actions for R-dev
03e3ed9
savingoyal
savingoyal requested changes Jun 8, 2020
View reviewed changes
Copy link
Collaborator

@savingoyal savingoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just took a cursory look at the code. I will play around with it in the next couple of days. Just added a few stylistic nits.

R/DESCRIPTION Outdated Show resolved Hide resolved
R/DESCRIPTION Outdated Show resolved Hide resolved
R/LICENSE Show resolved Hide resolved
R/NAMESPACE Show resolved Hide resolved
R/R/flags.R Show resolved Hide resolved
R/R/namespace.R Show resolved Hide resolved
R/R/run.R Outdated Show resolved Hide resolved
R/R/run.R Outdated Show resolved Hide resolved
R/tests/contexts.json Outdated Show resolved Hide resolved
R/tutorial/client_notebook.ipynb Outdated Show resolved Hide resolved
savingoyal
savingoyal requested changes Jun 8, 2020
View reviewed changes
.github/workflows/test_R.yml Outdated Show resolved Hide resolved
.github/workflows/test_R.yml Outdated Show resolved Hide resolved
.github/workflows/test_R.yml Outdated Show resolved Hide resolved
R/R/zzz.R Outdated Show resolved Hide resolved
savingoyal
savingoyal reviewed Jun 8, 2020
View reviewed changes
R/inst/run_batch.R Outdated Show resolved Hide resolved
@savingoyal savingoyal linked an issue Jun 8, 2020 that may be closed by this pull request
Support for the R programming language #1
Closed
jasonge27 and others added 26 commits August 3, 2020 14:51
@jasonge27
install python dependencies for R package from python side
1a22613
@savingoyal
Bug fix
086e358
@jasonge27
Merge branch 'R-dev' of github.com:Netflix/metaflow into R-dev
ec7ee45
@jasonge27
fixing conflcit with origin/R-dev
1d8f093
@jasonge27
fix a bug
34c04c8
@jasonge27
Merge branch 'master' into R-dev
9e09ca6
@savingoyal
Changes
3226ad7
@savingoyal
Merge branch 'R-dev' of https:/Netflix/metaflow into R-dev
8fb0555
@jasonge27 @savingoyal
Hooks for R bindings (#263)
f4332e6 
Hooks for R support for Metaflow

Co-authored-by: Savin <[email protected]>
@savingoyal
rebased changes
83a577c
@jasonge27
update README for R binding
f24bb9f
@jasonge27
update readme for R binding
6028c7c
@savingoyal
Mute all warnings
664e32c
@savingoyal
Merge branch 'R-dev' of https:/Netflix/metaflow into R-dev
8a41bfb
@savingoyal
Yank out $code
ccceebd
@savingoyal
Test out changes to gh-actions
30db8d2
@savingoyal
mo changes
4aab8c4
@savingoyal
Merge branch 'master' of https:/Netflix/metaflow into R-dev
12580e9
@savingoyal
Fix tests
d302419
@savingoyal
Yank out timeout
818a443
@savingoyal
Add environment
927e441
@savingoyal
uncomment code
2cb91ae
@savingoyal
mo changes
9f6c60a
@jasonge27
Merge branch 'master' into R-dev
3e483ad
@jasonge27
remove R tutorial tests for now
8a66a07
@savingoyal
Pin metaflow install to >=2.2.0
a020cf0
@savingoyal savingoyal merged commit 2cd1974 into master Aug 5, 2020
@savingoyal savingoyal deleted the R-dev branch August 5, 2020 04:59
@savingoyal savingoyal mentioned this pull request Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savingoyal savingoyal savingoyal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for the R programming language
2 participants
@jasonge27 @savingoyal