Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with adding compression to JSON-RPC #3008

Closed
MysticRyuujin opened this issue Apr 22, 2021 · 2 comments · Fixed by #3011
Closed

Experiment with adding compression to JSON-RPC #3008

MysticRyuujin opened this issue Apr 22, 2021 · 2 comments · Fixed by #3011

Comments

@MysticRyuujin
Copy link

When dealing with large debugs, adding compression to them can save literally GB in bandwidth.

E.G. the debug_traceTransaction of 0x7a97e47f9399b46c3e8ee444778763a4f331fa182b5c28c1ba98709721f71f7d will result in a stream that is 2849M in size. A simple gz of that output is 44M

Luk asked me to make an issue to experiment.

MysticRyuujin — Today at 10:30 AM
appears to work now
It's just streaming out to my system
lmao that's a 2849M stream, gzip into 44M
luk — Today at 10:35 AM
I could add compression to JSON RPC
MysticRyuujin — Today at 10:36 AM
I think that would make sense honestly, but idk how well zipping while streaming works if there's no buffer
maybe it works, idk :slight_smile:
luk — Today at 10:36 AM
we can experiment, can you add issue?
MysticRyuujin — Today at 10:36 AM
Sure

@tkstanczak
Copy link
Member

fantastic idea

@LukaszRozmej
Copy link
Member

Added to http, webcockets can get compression with .Net 6: dotnet/runtime#31088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants