Add System Transactions to mainnet #6206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekM25
reviewed
Jun 11, 2024
…h/nethermind into system_tx_experiment
rjnrohit
reviewed
Jun 19, 2024
src/Nethermind/Nethermind.Runner/Properties/launchSettings.json
Outdated
Show resolved
Hide resolved
rjnrohit
force-pushed
the
systemTx_experiment
branch
from
b625aa4
to
0c357ed
Compare
LukaszRozmej
requested changes
Jul 3, 2024
There was a problem hiding this comment.
I think splitting Transaction processors is a bad idea that will bring more harm than good.
I already see updates in main TransactionProcessor that weren't ported to the System one.
I also think that relying on parameters instead of decorators of IWolrdState/ICodeInfoRepository is also not great.
I can rework it, but first wanted to discuss my reservations and questions.
| @@ -132,6 +128,8 @@ public bool IsEip158IgnoredAccount(Address address) | |||
| public bool IsEip2935Enabled => _spec.IsEip2935Enabled; | |||
| public bool IsEip7709Enabled => _spec.IsEip7709Enabled; | |||
| public Address Eip2935ContractAddress => _spec.Eip2935ContractAddress; | |||
|
|
|||
| public bool AuRaSystemCalls => false; | |||
There was a problem hiding this comment.
shouldn't this be _spec.AuRaSystemCalls?
| { | ||
| throw new InvalidOperationException("Updating balance of a non-existing account"); | ||
| } | ||
| stateProvider.SubtractFromBalance(address, balanceChange, releaseSpec); |
There was a problem hiding this comment.
This could still underflow?
LukaszRozmej
reviewed
Jul 3, 2024
| @@ -256,10 +258,7 @@ private void ValidateProcessedBlock(Block suggestedBlock, ProcessingOptions opti | |||
| ReceiptsTracer.SetOtherTracer(blockTracer); | |||
| ReceiptsTracer.StartNewBlockTrace(block); | |||
|
|
|||
| _beaconBlockRootHandler.ApplyContractStateChanges(block, spec, _stateProvider); | |||
| _blockhashStore.ApplyBlockhashStateChanges(block.Header); | |||
There was a problem hiding this comment.
Is blockhash store also migrated to system calls?
|
closing in favor of #7252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.