Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add engine_getBlobsV1 #7322

Merged
merged 40 commits into from
Aug 24, 2024
Merged

Add engine_getBlobsV1 #7322

merged 40 commits into from
Aug 24, 2024

Conversation

marcindsobczak
Copy link
Contributor

@marcindsobczak marcindsobczak commented Aug 12, 2024 •
edited
Loading

Changes

  • Add engine_getBlobsV1 (spec)

Used string as a key in BlobIndex, because more intuitive byte[] (as we store blobVersionedHashes) were comparing keys by reference and we need to compare by value

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

docs will be automatically updated based on the added metadata

Requires explanation in Release Notes

  • Yes
  • No

@marcindsobczak marcindsobczak changed the title Add engine_getBlobsV1 [WIP] Add engine_getBlobsV1 Aug 12, 2024
@marcindsobczak marcindsobczak changed the title [WIP] Add engine_getBlobsV1 Add engine_getBlobsV1 Aug 14, 2024
@marcindsobczak marcindsobczak marked this pull request as ready for review August 14, 2024 11:41
@LukaszRozmej LukaszRozmej merged commit 062f240 into master Aug 24, 2024
66 checks passed
@LukaszRozmej LukaszRozmej deleted the add_engine_get_blobs_v1 branch August 24, 2024 08:20
@jimmygchen jimmygchen mentioned this pull request Aug 28, 2024
Open
1 task
@marcindsobczak marcindsobczak mentioned this pull request Sep 2, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe left review comments

@MarekM25 MarekM25 MarekM25 left review comments

@rubo rubo rubo approved these changes

@tanishqjasoria tanishqjasoria tanishqjasoria approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@flcl42 flcl42 Awaiting requested review from flcl42

Assignees
No one assigned
Labels
engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcindsobczak @karalabe @rubo @MarekM25 @tanishqjasoria @LukaszRozmej