Reduce contention in ClockCache #7338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartprogrammer93
approved these changes
Aug 16, 2024
Scooletz
reviewed
Aug 16, 2024
| @@ -21,6 +21,8 @@ public abstract class ClockCacheBase<TKey> | |||
| protected Queue<int> FreeOffsets { get; } = new(); | |||
|
|
|||
| protected int Clock { get; set; } = 0; | |||
| // Use local count to avoid lock contention with reads on ConcurrentDictionary.Count | |||
| protected int _count = 0; | |||
There was a problem hiding this comment.
Why introduce _count here while it's touched only by descendant classes?
| @@ -131,5 +137,5 @@ public bool Contains(TKey key) | |||
| return _cacheMap.ContainsKey(key); | |||
| } | |||
|
|
|||
| public int Count => _cacheMap.Count; | |||
| public int Count => _count; | |||
There was a problem hiding this comment.
Suggested change
| public int Count => _count; | |
| public int Count => Volatile.Read(ref _count); |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing