fix OverridableReleaseSpec EIP158 and adjust TxPriorityContractTests #7351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekM25
reviewed
Aug 21, 2024
alexb5dh
reviewed
Aug 21, 2024
src/Nethermind/Nethermind.AuRa.Test/Contract/TestContractBlockchain.cs
Outdated
Show resolved
Hide resolved
alexb5dh
reviewed
Aug 21, 2024
| @@ -55,7 +55,7 @@ public OverridableReleaseSpec(IReleaseSpec spec) | |||
|
|
|||
| public bool IsEip155Enabled => _spec.IsEip155Enabled; | |||
|
|
|||
| public bool IsEip158Enabled => _spec.IsEip1559Enabled; | |||
| public bool IsEip158Enabled => _spec.IsEip158Enabled; | |||
There was a problem hiding this comment.
Is existing logic a bug or was it intended for something?
There was a problem hiding this comment.
bug, but it was only used in tests and didn't really affect much of them except that one :)
alexb5dh
approved these changes
Aug 21, 2024
This reverts commit d2c3007.
|
This changes are now included in #7252 and lets merge that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?