Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Shutter Optimisation #7592

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Minor Shutter Optimisation #7592

merged 2 commits into from
Oct 11, 2024
+49 −37

Conversation

Marchhill
Copy link
Contributor

Changes

  • Use SkipLocalsInit in Shutter cryptography
  • Rename some variables for clarity
  • Remove GetPublicKey function that encourages heap allocation

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@Marchhill Marchhill merged commit 54a795c into master Oct 11, 2024
73 checks passed
@Marchhill Marchhill deleted the feature/gnosis-shutter-optimistations branch October 11, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marchhill @LukaszRozmej