Look for Colab badges and redirect them to master #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fingers crossed that we're not in "now we have two problems" territory here. |
mwaskom
added
the
Infrastructure
patrickmineault
requested changes
Jun 21, 2020
| def redirect_colab_badge(cell): | ||
| """Modify the Colab badge to point at the master branch on Github.""" | ||
| cell_text = cell["source"] | ||
| p = re.compile(r"^(.+/NeuromatchAcademy/course-content/blob/)\w+(/.+$)") |
There was a problem hiding this comment.
I think this wouldn't work if someone pulls in from a fork.
There was a problem hiding this comment.
That's true. But is that the workflow we're going to use? I'm not sure this bit of processing can solve all problems — we'd also have to replace the repository name in the badge then too.
Canonical Colab links should probably be hand-curated in the README / on the website.
|
Let's get this merged for now since it works for the workflow we currently prescribe. We can keep an open issue about broken badges for colabs that come in from a feature on a fork. |
patrickmineault
approved these changes
Jun 21, 2020
This was referenced Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81