Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find subpath method #14

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Find subpath method #14

merged 4 commits into from
Aug 29, 2023

Conversation

halgari
Copy link
Contributor

@halgari halgari commented Aug 29, 2023

A new property 'Depth' and a new method 'FindSubPath' were added to 'FileTreeNode'. 'Depth' is a ushort that represents a node's depth in the tree and can be used for various calculations. 'FindSubPath' is a function that returns all nodes that match a given subpath. This enhancement will allow more complex manipulations and considerations of the file tree hierarchy. Meanwhile, a test for 'FindSubPath' has been implemented in 'RelativeFileTreeTests'.

A new property 'Depth' and a new method 'FindSubPath' were added to 'FileTreeNode'. 'Depth' is a ushort that represents a node's depth in the tree and can be used for various calculations. 'FindSubPath' is a function that returns all nodes that match a given subpath. This enhancement will allow more complex manipulations and considerations of the file tree hierarchy. Meanwhile, a test for 'FindSubPath' has been implemented in 'RelativeFileTreeTests'.
@halgari halgari requested a review from a team August 29, 2023 18:11
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Patch coverage: 72.72% and project coverage change: -0.03% ⚠️

Comparison is base (723c454) 77.33% compared to head (ccffa56) 77.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   77.33%   77.30%   -0.03%     
==========================================
  Files          35       35              
  Lines        1747     1780      +33     
  Branches      298      304       +6     
==========================================
+ Hits         1351     1376      +25     
- Misses        340      347       +7     
- Partials       56       57       +1     
Flag Coverage Δ
Linux 76.74% <72.72%> (-0.02%) ⬇️
Windows 76.74% <72.72%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/NexusMods.Paths/FileTree/FileTreeNode.cs 83.07% <72.72%> (-3.53%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/NexusMods.Paths/FileTree/FileTreeNode.cs Outdated Show resolved Hide resolved
src/NexusMods.Paths/FileTree/FileTreeNode.cs Outdated Show resolved Hide resolved
@halgari halgari merged commit efc3a61 into main Aug 29, 2023
3 checks passed
@halgari halgari deleted the find-subpath-method branch August 29, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants