Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved 'Parts' method for RelativePath #34

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented Dec 5, 2023

@Sewer56 Sewer56 added the meta-performance Anywhere we might get an improvement in performance. label Dec 5, 2023
@Sewer56 Sewer56 requested a review from a team December 5, 2023 21:21
@Sewer56 Sewer56 self-assigned this Dec 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (9aff411) 86.71% compared to head (c00a069) 86.15%.
Report is 2 commits behind head on main.

Files Patch % Lines
...Mods.Paths/FileSystemAbstraction/BaseFileSystem.cs 10.00% 18 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   86.71%   86.15%   -0.57%     
==========================================
  Files          42       42              
  Lines        2861     2875      +14     
  Branches      494      494              
==========================================
- Hits         2481     2477       -4     
- Misses        324      342      +18     
  Partials       56       56              
Flag Coverage Δ
Linux 85.73% <51.35%> (-0.56%) ⬇️
Windows 85.73% <51.35%> (-0.56%) ⬇️
macOS 85.66% <51.35%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Al12rs
Copy link
Contributor

Al12rs commented Dec 6, 2023

The signed commits again? Didn't we disable that?

@erri120 erri120 linked an issue Dec 6, 2023 that may be closed by this pull request
@Sewer56
Copy link
Member Author

Sewer56 commented Dec 6, 2023

We set that up at Template repo, so this has to be toggled for every repo that was based on that individually. We must have not done it here yet.

@halgari halgari merged commit 2e663e0 into main Dec 7, 2023
5 checks passed
@halgari halgari deleted the improve-get-parts branch December 7, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-performance Anywhere we might get an improvement in performance.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve: Parts performance for 'RelativePath' for Tree Creation
4 participants