Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TemporaryFileManager not deleting directories correctly #36

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Feb 5, 2024

fixes Nexus-Mods/NexusMods.App#904

When adding the test I found that the InMemoryFS was throwing when deleting the folder recursively, so fixed that as well.

@Al12rs Al12rs requested a review from a team February 5, 2024 12:33
@Al12rs Al12rs self-assigned this Feb 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ab2d282) 87.19% compared to head (d19fd49) 86.94%.

Files Patch % Lines
...straction/InMemoryFileSystem/InMemoryFileSystem.cs 72.22% 4 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   87.19%   86.94%   -0.25%     
==========================================
  Files          42       42              
  Lines        3123     3148      +25     
  Branches      537      542       +5     
==========================================
+ Hits         2723     2737      +14     
- Misses        343      347       +4     
- Partials       57       64       +7     
Flag Coverage Δ
Linux ?
Windows 86.94% <81.48%> (+0.13%) ⬆️
macOS ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Al12rs Al12rs merged commit e512640 into main Feb 5, 2024
5 checks passed
@Al12rs Al12rs deleted the fix_temp_directories branch February 5, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

App does not cleanup extracted files after mod installation
4 participants