Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --verify in Nixpkgs diff CI #215

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Use --verify in Nixpkgs diff CI #215

merged 1 commit into from
Jul 16, 2024

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Jul 9, 2024

Makes sure that when testing formatting on all of Nixpkgs, the AST doesn't change, important for NixOS/nixpkgs#322520

This does make the Nixpkgs diff CI like 1 minute slower per commit, but this seems worth it.

Also discovered another bug from this, fix: #217

Copy link

github-actions bot commented Jul 9, 2024

Nixpkgs diff

@infinisil infinisil force-pushed the verify branch 3 times, most recently from e2a9aed to ba9cd57 Compare July 9, 2024 18:47
This was referenced Jul 9, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/formatting-team-meeting-2024-07-09/48759/1

@infinisil infinisil marked this pull request as ready for review July 12, 2024 18:21
@infinisil infinisil linked an issue Jul 12, 2024 that may be closed by this pull request
@infinisil infinisil merged commit f09ce41 into master Jul 16, 2024
2 checks passed
@infinisil infinisil deleted the verify branch July 16, 2024 16:26
infinisil added a commit to tweag/nixpkgs that referenced this pull request Jul 18, 2024
Update it to https://hydra.nixos.org/eval/1807730#tabs-inputs, which
notably contains some fixes for nixfmt: NixOS/nixfmt#215
infinisil added a commit to NixOS/nixpkgs that referenced this pull request Jul 18, 2024
Update it to https://hydra.nixos.org/eval/1807730#tabs-inputs, which
notably contains some fixes for nixfmt: NixOS/nixfmt#215

(cherry picked from commit 8e1b9b9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Nixpkgs diff check should run with --verify
3 participants