Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awesome-lint: init at v0.18.0 #144938

Merged
merged 1 commit into from
Nov 10, 2021
Merged

awesome-lint: init at v0.18.0 #144938

merged 1 commit into from
Nov 10, 2021

Conversation

cyntheticfox
Copy link
Contributor

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Closes #117236

@r-burns
Copy link
Contributor

r-burns commented Nov 7, 2021

Heads up that this now conflicts because your other nodePackages PR got merged.

Also, this is a bit of a "dark nixpkgs" tip, but if you are annoyed by merge conflicts you can just add the package you want to node-packages.json and let it get added next time someone else generates the .nix file.

@cyntheticfox
Copy link
Contributor Author

It's a little annoying, for how nodePackages works, but it's not too bad. It just takes like 2 hours for my computer to generate it 👀. Waiting on a regeneration of node-packages.nix now.

Signed-off-by: David Houston <[email protected]>
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

awesome-lint
3 participants