python3.pkgs.thinc: fix build #222275
python3.pkgs.thinc: fix build #222275
Conversation
| @@ -71,6 +71,10 @@ buildPythonPackage rec { | |||
| pytestCheckHook | |||
| ]; | |||
|
|
|||
| postPatch = '' | |||
| substituteInPlace setup.cfg --replace "blis>=0.7.8,<0.8.0" "blis" | |||
There was a problem hiding this comment.
Note you can often use pythonRelaxDepsHook to relax or remove a dependency.
There was a problem hiding this comment.
@bcdarwin I tried that. but it doesn't seem to affect setup.cfg. I was looking at the pythoinRelexDepsHook shell script, but its still a mystery what files they will act on. by the way. really appreciate that you review my MRs. thanks.
There was a problem hiding this comment.
Please don't do this. BLIS 0.9.x is broken and causes segfaults. The upper bound of 0.8.0 is there for a reason.
There was a problem hiding this comment.
thanks for spotting this. I will close it now.
There was a problem hiding this comment.
@danieldk, shall we revert blis to version 0.7.9, so it is breaking spacy?
There was a problem hiding this comment.
Yeah, I did that before, but a mass-update undid it again. There is a suggestion here:
to prevent that from happening in the future
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)