Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dt-schema, python3.pkgs.dtschema: handle jsonschema incompatibility #247379

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 5, 2023

Description of changes

  1. dt-schema is an application, so it can pin jsonschema to 4.17
  2. mark python3.pkgs.dtschema broken with jsonschema > 4.17
  3. mark python3.pkgs.dtschema broken on Darwin

Some context about each of these points:

  1. Per discussion in Raising the jsonschema cap to allow 4.18.* devicetree-org/dt-schema#108, dt-schema will need more time before it can support jsonschema 4.18.
  2. The package even on master is broken on Darwin right now.

This is currently broken on staging-next (#245935).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

1. dt-schema is an application, so it can pin jsonschema to 4.17
2. mark python3.pkgs.dtschema broken with jsonschema > 4.17
3. mark python3.pkgs.dtschema broken on darwin
@vcunat vcunat merged commit 3858a9b into NixOS:staging-next Aug 8, 2023
8 checks passed
@tjni tjni deleted the dtschema branch August 8, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants