Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge-runtime: 1.10.0 -> 1.14.0 #253180

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

happysalada
Copy link
Contributor

@happysalada happysalada commented Sep 3, 2023

Description of changes

update of the package to fix build with rust 1.72

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@happysalada
Copy link
Contributor Author

Result of nixpkgs-review pr 253180 run on x86_64-linux 1

1 package failed to build:
  • edge-runtime

@happysalada
Copy link
Contributor Author

Result of nixpkgs-review pr 253180 run on x86_64-linux 1

1 package built:
  • edge-runtime

@vcunat
Copy link
Member

vcunat commented Sep 4, 2023

FYI, ofBorg says that darwin needs more fixes. Hydra says it did build on current nixpkgs master. But sure, it's better when at least part is fixed than nothing.

@happysalada
Copy link
Contributor Author

the error was a missing SystemConfiguration, I've just added it.

@happysalada
Copy link
Contributor Author

alright, the darwin build just timed out, I'm going to merge then.
Thanks for reviewing!

@happysalada happysalada merged commit bcbbfd8 into NixOS:staging-next Sep 4, 2023
8 checks passed
@happysalada happysalada deleted the update_edge_runtime branch September 4, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants