mesen: init at 2.0.0-unstable-2024-09-15 #301666

TomaSajt · 2024-04-04T23:00:10Z

Description of changes

Closes #301132

Core build time is ~10mins for me.

I only tested SMB for the NES.

Things done

Add a 👍 reaction to pull requests you find important.

keenanweaver · 2024-04-05T22:27:17Z

Result of nixpkgs-review pr 301666 run on x86_64-linux 1

1 package built:

mesen

keenanweaver

Building perfectly (albeit a long one as noted). All functionality is working (Saving demos, netplay, debugging tools, etc. What a cool emulator!) Only quirk I've noticed is the 'build date' on the about screen being Jan 1 1980, but not a big deal.

keenanweaver · 2024-06-03T22:10:07Z

Could this be eligible for the unstable updater? https:/NixOS/nixpkgs/blob/master/pkgs/common-updater/unstable-updater.nix

TomaSajt · 2024-06-03T22:21:38Z

Could this be eligible for the unstable updater? https:/NixOS/nixpkgs/blob/master/pkgs/common-updater/unstable-updater.nix

Probably not, since this package needs a generated deps.nix file for dotnet packages.

AtomicTroop · 2024-08-20T15:40:07Z

What's currently pending for this one? I could definitely use this package for NES debugging, so if there's anything I can help with to move this forwards, please let me know.

FlafyDev · 2024-09-03T19:39:56Z

I'm getting this error

❯ nix run github:TomaSajt/nixpkgs/mesen2#mesen
error: builder for '/nix/store/kjwrck5dfaig3bvnxqgw8qxqzm9yami5-mesen-2.0.0-unstable-2024-06-01.drv' failed with exit code 1;
       last 10 log lines:
       > patching file UI/Config/ConfigManager.cs
       > patching file UI/Program.cs
       > patching file UI/UI.csproj
       > Running phase: configureNuget
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > Executing dotnetConfigureHook
       >   Determining projects to restore...
       > /build/source/UI/UI.csproj : error NU1301: Unable to load the service index for source https://nuget-feed-nightly.avaloniaui.net/v3/index.json.
       >   Failed to restore /build/source/UI/UI.csproj (in 5.5 sec).
       For full logs, run 'nix log /nix/store/kjwrck5dfaig3bvnxqgw8qxqzm9yami5-mesen-2.0.0-unstable-2024-06-01.drv'.

TomaSajt · 2024-09-03T19:44:46Z

I'm getting this error

❯ nix run github:TomaSajt/nixpkgs/mesen2#mesen
error: builder for '/nix/store/kjwrck5dfaig3bvnxqgw8qxqzm9yami5-mesen-2.0.0-unstable-2024-06-01.drv' failed with exit code 1;
       last 10 log lines:
       > patching file UI/Config/ConfigManager.cs
       > patching file UI/Program.cs
       > patching file UI/UI.csproj
       > Running phase: configureNuget
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > Executing dotnetConfigureHook
       >   Determining projects to restore...
       > /build/source/UI/UI.csproj : error NU1301: Unable to load the service index for source https://nuget-feed-nightly.avaloniaui.net/v3/index.json.
       >   Failed to restore /build/source/UI/UI.csproj (in 5.5 sec).
       For full logs, run 'nix log /nix/store/kjwrck5dfaig3bvnxqgw8qxqzm9yami5-mesen-2.0.0-unstable-2024-06-01.drv'.

Yes, sorry about that, I should have probably put the PR into draft.

I'm still working on updating to the latest version but I'm having some issues. I'll try to fix this current one for now.
I'll be away this week but I'll try to do what I can.

TomaSajt · 2024-09-03T22:02:17Z

Updated to the latest commit before update to Avalonia 11.1, which breaks the build (duplicate asset errors and elements just not compiling). I have no idea how to use Avalonia or why it broke, so this is as far as I could go for now.

TomaSajt · 2024-09-18T16:29:12Z

Now that #340493 is fixed I could update to a later commit more easily.

FavoritoHJS · 2024-10-14T20:03:21Z

I'm getting a problem when starting up the program, and i don't know where else to ask...

When trying to start the program, the following gets printed out and the program crashes:

Unhandled exception. System.ArgumentException: An item with the same key has already been added. Key: /Assets/NesIcon.png
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
   at System.Linq.Enumerable.ToDictionary[TSource,TKey,TElement](List`1 source, Func`2 keySelector, Func`2 elementSelector, IEqualityComparer`1 comparer)
   at Avalonia.Platform.Internal.AssemblyDescriptor..ctor(Assembly assembly)
   at Avalonia.Platform.StandardAssetLoader..ctor(IAssemblyDescriptorResolver resolver, Assembly assembly)
   at Avalonia.Platform.StandardAssetLoader..ctor(Assembly assembly)
   at Avalonia.Platform.StandardRuntimePlatformServices.Register(Assembly assembly)
   at Avalonia.AppBuilder.<UseStandardRuntimePlatformSubsystem>b__68_0()
   at Avalonia.AppBuilder.SetupUnsafe()
   at Avalonia.AppBuilder.Setup()
   at Avalonia.AppBuilder.SetupWithLifetime(IApplicationLifetime lifetime)
   at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime(AppBuilder builder, String[] args, ShutdownMode shutdownMode)
   at Mesen.Program.Main(String[] args) in /build/source/UI/Program.cs:line 58
Aborted (core dumped)

I really need this to work as this is the only program pvsneslib supports for its debug files...

EDIT: I'm using the following to enter a nix shell with Mesen on the path:

{pkgs ? import <nixpkgs>{}, ...}:
let
mesen = pkgs.callPackage ./mesen.nix {};
in
pkgs.mkShell{
  packages = [mesen];
}

TomaSajt · 2024-10-14T20:16:40Z

I'm getting a problem when starting up the program, and i don't know where else to ask...

When trying to start the program, the following gets printed out and the program crashes:

Unhandled exception. System.ArgumentException: An item with the same key has already been added. Key: /Assets/NesIcon.png
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
   at System.Linq.Enumerable.ToDictionary[TSource,TKey,TElement](List`1 source, Func`2 keySelector, Func`2 elementSelector, IEqualityComparer`1 comparer)
   at Avalonia.Platform.Internal.AssemblyDescriptor..ctor(Assembly assembly)
   at Avalonia.Platform.StandardAssetLoader..ctor(IAssemblyDescriptorResolver resolver, Assembly assembly)
   at Avalonia.Platform.StandardAssetLoader..ctor(Assembly assembly)
   at Avalonia.Platform.StandardRuntimePlatformServices.Register(Assembly assembly)
   at Avalonia.AppBuilder.<UseStandardRuntimePlatformSubsystem>b__68_0()
   at Avalonia.AppBuilder.SetupUnsafe()
   at Avalonia.AppBuilder.Setup()
   at Avalonia.AppBuilder.SetupWithLifetime(IApplicationLifetime lifetime)
   at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime(AppBuilder builder, String[] args, ShutdownMode shutdownMode)
   at Mesen.Program.Main(String[] args) in /build/source/UI/Program.cs:line 58
Aborted (core dumped)

I really need this to work as this is the only program pvsneslib supports for its debug files...

EDIT: I'm using the following to enter a nix shell with Mesen on the path:

{pkgs ? import <nixpkgs>{}, ...}:
let
mesen = pkgs.callPackage ./mesen.nix {};
in
pkgs.mkShell{
  packages = [mesen];
}

You shouldn't be using your own <nixpkgs>, since it's missing crucial fixes for the AvaloniaUI ecosystem.

I advise you update your <nixpkgs> channel to a more recent version
or that you replace the <nixpkgs> expression with (builtins.fetchTarball { url = "https:/TomaSajt/nixpkgs/archive/mesen2.tar.gz"; sha256 = ""; })

This way you can even just write pkgs.mesen instead of using callPackage with a copy of the .nix file

Or if you don't need it in a shell.nix file, you could just do

nix-shell -I nixpkgs=https:/TomaSajt/nixpkgs/archive/mesen2.tar.gz -p mesen

FavoritoHJS · 2024-10-14T20:43:31Z

that fixed it! thank you

FliegendeWurst · 2024-10-17T14:32:09Z

Doesn't build for me:

Executing dotnetConfigureHook
  Determining projects to restore...
/build/source/UI/UI.csproj : error NU1102: Unable to find package Microsoft.NETCore.App.Host.win-x64 with version (= 8.0.10)
/build/source/UI/UI.csproj : error NU1102:   - Found 1 version(s) in _nix [ Nearest version: 8.0.8 ]
  Failed to restore /build/source/UI/UI.csproj (in 254 ms).

TomaSajt · 2024-10-17T15:09:04Z

Doesn't build for me:

Executing dotnetConfigureHook
  Determining projects to restore...
/build/source/UI/UI.csproj : error NU1102: Unable to find package Microsoft.NETCore.App.Host.win-x64 with version (= 8.0.10)
/build/source/UI/UI.csproj : error NU1102:   - Found 1 version(s) in _nix [ Nearest version: 8.0.8 ]
  Failed to restore /build/source/UI/UI.csproj (in 254 ms).

@corngood could you help with this? I'm not exactly sure how these AppHost things work...

pkgs/by-name/me/mesen/package.nix

corngood · 2024-10-17T18:05:38Z

Result of nixpkgs-review pr 301666 run on x86_64-linux 1

1 package failed to build:

mesen

corngood · 2024-10-17T18:29:08Z

@corngood could you help with this? I'm not exactly sure how these AppHost things work...

I think you just need:

diff --git a/pkgs/by-name/me/mesen/package.nix b/pkgs/by-name/me/mesen/package.nix
index a5fd5a47f1a2..bc8d722799c3 100644
--- a/pkgs/by-name/me/mesen/package.nix
+++ b/pkgs/by-name/me/mesen/package.nix
@@ -37,6 +37,10 @@ buildDotnetModule rec {
 
   projectFile = [ "UI/UI.csproj" ];
 
+  dotnetFlags = [
+    "-p:RuntimeIdentifier=${dotnetCorePackages.systemToDotnetRid clangStdenv.hostPlatform.system}"
+  ];
+
   executables = [ "Mesen" ];
 
   nugetDeps = ./deps.nix;

To stop it from overriding the RID to windows. That's a property they set in their makefile. You should then re-run fetch-deps, which should remove Microsoft.NETCore.App.Host.win-x64 from the lock file.

keenanweaver · 2024-10-18T00:23:32Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 301666

`x86_64-linux`

✅ 1 package built:

mesen

TomaSajt · 2024-10-18T05:02:14Z

Seems like updating broke the non x86-64-linux builds. Will look into it

TomaSajt · 2024-10-19T22:33:03Z

Reverted to the working version, for now.

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 4, 2024

keenanweaver approved these changes Apr 5, 2024

View reviewed changes

wegank added the 12.approvals: 1 label Apr 5, 2024

jtbx approved these changes May 13, 2024

View reviewed changes

wegank added 12.approvals: 2 and removed 12.approvals: 1 labels May 22, 2024

TomaSajt force-pushed the mesen2 branch from 7cd9b6a to 4aa0ec1 Compare June 3, 2024 22:47

wegank removed the 12.approvals: 2 label Jun 20, 2024

TomaSajt force-pushed the mesen2 branch from 4aa0ec1 to 8ac6dcd Compare August 20, 2024 16:29

TomaSajt force-pushed the mesen2 branch from 8ac6dcd to 2b4b51d Compare September 3, 2024 20:14

TomaSajt changed the title ~~mesen: init at 2.0.0-unstable-2024-04-03~~ mesen: init at 2.0.0-unstable-2024-06-01 Sep 3, 2024

TomaSajt force-pushed the mesen2 branch from 2b4b51d to 493650d Compare September 3, 2024 22:00

TomaSajt changed the title ~~mesen: init at 2.0.0-unstable-2024-06-01~~ mesen: init at 2.0.0-unstable-2024-07-27 Sep 3, 2024

TomaSajt force-pushed the mesen2 branch from 493650d to d44371f Compare September 8, 2024 17:16

TomaSajt force-pushed the mesen2 branch 2 times, most recently from 6661b6f to 0056e06 Compare September 18, 2024 16:26

TomaSajt changed the title ~~mesen: init at 2.0.0-unstable-2024-07-27~~ mesen: init at 2.0.0-unstable-2024-09-15 Sep 18, 2024

TomaSajt force-pushed the mesen2 branch from 0056e06 to 8201e97 Compare October 8, 2024 16:02

corngood reviewed Oct 17, 2024

View reviewed changes

pkgs/by-name/me/mesen/package.nix Show resolved Hide resolved

TomaSajt force-pushed the mesen2 branch 2 times, most recently from 5b0562f to 2b20bdb Compare October 17, 2024 22:20

TomaSajt changed the title ~~mesen: init at 2.0.0-unstable-2024-09-15~~ mesen: init at 2.0.0-unstable-2024-10-17 Oct 17, 2024

keenanweaver approved these changes Oct 18, 2024

View reviewed changes

mesen: init at 2.0.0-unstable-2024-09-15

3fcec3d

TomaSajt force-pushed the mesen2 branch from 2b20bdb to 3fcec3d Compare October 19, 2024 22:31

TomaSajt changed the title ~~mesen: init at 2.0.0-unstable-2024-10-17~~ mesen: init at 2.0.0-unstable-2024-09-15 Oct 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mesen: init at 2.0.0-unstable-2024-09-15 #301666

mesen: init at 2.0.0-unstable-2024-09-15 #301666

TomaSajt commented Apr 4, 2024 •

edited

Loading

keenanweaver commented Apr 5, 2024

keenanweaver left a comment

keenanweaver commented Jun 3, 2024

TomaSajt commented Jun 3, 2024

AtomicTroop commented Aug 20, 2024

FlafyDev commented Sep 3, 2024

TomaSajt commented Sep 3, 2024

TomaSajt commented Sep 3, 2024

TomaSajt commented Sep 18, 2024

FavoritoHJS commented Oct 14, 2024 •

edited

Loading

TomaSajt commented Oct 14, 2024 •

edited

Loading

FavoritoHJS commented Oct 14, 2024

FliegendeWurst commented Oct 17, 2024

TomaSajt commented Oct 17, 2024

corngood commented Oct 17, 2024

corngood commented Oct 17, 2024

keenanweaver commented Oct 18, 2024

TomaSajt commented Oct 18, 2024

TomaSajt commented Oct 19, 2024

mesen: init at 2.0.0-unstable-2024-09-15 #301666

Are you sure you want to change the base?

mesen: init at 2.0.0-unstable-2024-09-15 #301666

Conversation

TomaSajt commented Apr 4, 2024 • edited Loading

Description of changes

Things done

keenanweaver commented Apr 5, 2024

keenanweaver left a comment

Choose a reason for hiding this comment

keenanweaver commented Jun 3, 2024

TomaSajt commented Jun 3, 2024

AtomicTroop commented Aug 20, 2024

FlafyDev commented Sep 3, 2024

TomaSajt commented Sep 3, 2024

TomaSajt commented Sep 3, 2024

TomaSajt commented Sep 18, 2024

FavoritoHJS commented Oct 14, 2024 • edited Loading

TomaSajt commented Oct 14, 2024 • edited Loading

FavoritoHJS commented Oct 14, 2024

FliegendeWurst commented Oct 17, 2024

TomaSajt commented Oct 17, 2024

corngood commented Oct 17, 2024

corngood commented Oct 17, 2024

keenanweaver commented Oct 18, 2024

nixpkgs-review result

x86_64-linux

TomaSajt commented Oct 18, 2024

TomaSajt commented Oct 19, 2024

TomaSajt commented Apr 4, 2024 •

edited

Loading

FavoritoHJS commented Oct 14, 2024 •

edited

Loading

TomaSajt commented Oct 14, 2024 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`