mpvScripts.smart-copy-paste-2: init at 0-unstable-2023-11-25

[luftmensch-luftmensch]

Description of changes

Closes #309528

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[luftmensch-luftmensch]

> nix build .#mpvScripts.smart-copy-paste-2
> tree result/
 result
└──  share
   └──  mpv
      └──  scripts
         └──  SmartCopyPaste_II.lua

Tested also with:

mpv --load-scripts --script=./result/share/mpv/scripts/SmartCopyPaste_II.lua /path/to/file_video

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3951

[FliegendeWurst]

I just checked the source code of the script and it depends on xclip / pbclip to work. So those need to be provided.

[luftmensch-luftmensch]

Since pbclip is not present on nixpkgs should I mark this package broken on mac?

[FliegendeWurst]

Hmm, it might be that pbclip is included in the base MacOS installation.

[luftmensch-luftmensch]

@FliegendeWurst Should be good to go now

[FliegendeWurst]

I don't think adding it to buildInputs works. I think it is easiest to patch the source using substituteInPlace.

[luftmensch-luftmensch]

Isn't buildInputs for programs and libraries used by the new derivation at run-time?

[FliegendeWurst]

Libraries, yes.