Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages: Assorted build fixes #342755

Merged
merged 10 commits into from
Oct 19, 2024

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Sep 18, 2024

This is for merging into the haskell-updates branch (PR #339272).

Tested the build with:

nix build --impure --expr 'let pkgs = (import ./. { system = "x86_64-linux"; });
in pkgs.haskellPackages.ghcWithHoogle (ps: with ps; [
  gi-gtk-declarative
  gi-gtk-declarative-app-simple
  reflex-gloss
  reflex-gi-gtk
  reflex-sdl2
  pipes-extras
  pipes-http
  vivid
  dear-imgui
])'

Upstream PRs:

@maralorn
Copy link
Member

This is amazingly thorough. Thank you so much.

I was just confused by vivid missing a link until I read the commit message. Would you mind putting that message into a comment anyway? Then the next time someone tries to figure out whether they can drop the override they don’t go looking for the repo.

@rvl rvl force-pushed the haskell-updates-misc-fixes branch from 8116e92 to 33ff80b Compare October 18, 2024 01:46
@rvl
Copy link
Contributor Author

rvl commented Oct 18, 2024

Would you mind putting that message into a comment anyway?

OK, done, thanks @maralorn.

Also while looking for the author's e-mail address, I noticed that vivid-0.5.2.1 was released about a week ago, which fixes the compile error.

This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
@maralorn
Copy link
Member

Excellent!

@maralorn maralorn merged commit 6553550 into NixOS:haskell-updates Oct 19, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants