webkitgtk: refactor top-level to deprecate default ABI version #345611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianhjr
commented
Sep 30, 2024
fabianhjr
force-pushed
the
refactor-webkitgtk
branch
from
062ed62
to
5a6bcc9
Compare
fabianhjr
changed the title
fabianhjr
changed the title
fabianhjr
force-pushed
the
refactor-webkitgtk
branch
from
5a6bcc9
to
1da61e6
Compare
khaneliman
approved these changes
Oct 4, 2024
fabianhjr
requested review from
mmahut,
RaghavSood,
adisbladis,
sternenseemann and
maralorn
as code owners
fabianhjr
force-pushed
the
refactor-webkitgtk
branch
3 times, most recently
from
6a1d60f
to
5be77d0
Compare
|
|
Result of 4 packages built:
|
|
Cleaned up the tree @jtojnar, will wait a bit for feedback but this seems mergeable as is. |
error: function 'anonymous lambda' called without required argument 'webkitgtk_4_0-web-process-extension'
at /ofborg/checkout/2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-1/pkgs/development/haskell-modules/hackage-packages.nix:124272:6:
124271| "gi-webkitwebprocessextension" = callPackage
124272| ({ mkDerivation, base, bytestring, Cabal, containers, gi-gdk
| ^
124273| , gi-gio, gi-gobject, gi-gtk, gi-javascriptcore, gi-soup |
fabianhjr
force-pushed
the
refactor-webkitgtk
branch
2 times, most recently
from
a41c3a6
to
8ae3ae4
Compare
|
Addressed all your comments @jtojnar, thanks for the review. :3 |
jtojnar
reviewed
Oct 11, 2024
fabianhjr
force-pushed
the
refactor-webkitgtk
branch
2 times, most recently
from
3f3fabb
to
2c69010
Compare
|
Working on rebase |
sed -i 's/ webkitgtk\b/ webkitgtk_4_0/g' pkgs/**.nix sed -i 's/(webkitgtk\b/(webkitgtk_4_0/g' pkgs/**.nix sed -i 's/\.webkitgtk\b/.webkitgtk_4_0/g' pkgs/**.nix webkitgtk is currently pointing to that specific ABI version but the alias is going to start warning
fabianhjr
force-pushed
the
refactor-webkitgtk
branch
from
2c69010
to
b9a93b6
Compare
|
RossComputerGuy
approved these changes
Oct 12, 2024
K900
approved these changes
Oct 12, 2024
|
Detects the webkitgtk_4_0 as a new package so hasn't reported 0. :c Labelled as 1 rebuild on previous evals |
|
@ofborg eval |
|
Eval finished as 1 rebuild due to webkitgtk_4_0 being treated as a new package |
sternenseemann
added a commit
that referenced
this pull request
Oct 14, 2024
This commit partially reverts ccec93c. This will break a lot of packages in haskellPackages (due to a missing webkitgtk), but at least hackage-packages.nix is reproducible with the generation shell script again. Unfortunately, it seems the generated nature of hackage-packages.nix was ignored when preparing the webkitgtk change: #345611 (comment)
sternenseemann
added a commit
to fabianhjr/cabal2nix
that referenced
this pull request
Oct 17, 2024
When we don't know the exact version from the cabal file, we still emit the generic name that has recently been removed from nixpkgs safe for an alias (NixOS/nixpkgs#345611) which we can't use in hackage-packages.nix. This is still the best solution for downstream expressions generated by cabal2nix, in nixpkgs we'll have to manually specify the correct version (instead of hackage2nix picking the default which may not always be correct). Co-authored-by: sternenseemann <[email protected]>
sternenseemann
added a commit
to fabianhjr/cabal2nix
that referenced
this pull request
Oct 17, 2024
When we don't know the exact version from the cabal file, we still emit the generic name that has recently been removed from nixpkgs safe for an alias (NixOS/nixpkgs#345611) which we can't use in hackage-packages.nix. This is still the best solution for downstream expressions generated by cabal2nix, in nixpkgs we'll have to manually specify the correct version (instead of hackage2nix picking the default which may not always be correct). Co-authored-by: sternenseemann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is to avoid breaking things by changing the default version and making dependents more explicit about such dependency
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.