Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dwlb: add option to set custom config.h #349363

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lonyelon
Copy link
Contributor

@lonyelon lonyelon commented Oct 17, 2024

This is a required feature to configure the bar, as it follows the SUCKLESS way of working (configuration as C code).

This was included in #325656, but missing in #341168, which ended up being the merged PR.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/dw/dwlb/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/dw/dwlb/package.nix Show resolved Hide resolved
pkgs/by-name/dw/dwlb/package.nix Show resolved Hide resolved
pkgs/by-name/dw/dwlb/package.nix Show resolved Hide resolved
pkgs/by-name/dw/dwlb/package.nix Outdated Show resolved Hide resolved
@lonyelon lonyelon force-pushed the add-missing-dwlb-configh branch 2 times, most recently from cd3dade to ba86dae Compare October 19, 2024 11:18
@Bot-wxt1221 Bot-wxt1221 self-requested a review October 19, 2024 11:30
@lonyelon lonyelon self-assigned this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants